Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split yspace inputs in backward and forward #166

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GuiMacielPereira
Copy link
Collaborator

@GuiMacielPereira GuiMacielPereira commented Jan 17, 2025

Description of work:
Anna requested that due to new requirements, the fit in y-space routine needs to be run for both backward and forward routines, but with different inputs. Easiest way to achieve this is to split the y-space inputs into the two classes of analysis inputs for both forward and backward.

To test:
Create and sctivate a test environment with mantidworkbench installed:

  • Checkout this branch and install with pip install -e .
  • Run mvesuvio config
  • Open Mantid workbench and open file ~/.mvesuvio/analysis_inputs.py
  • In the class BackwardAnalysisInputs change the field run_this_scattering_type = True and in ForwardAnalysisInputs change run_this_scattering_type = False
  • Click Run and check that the script runs without errors
  • In the class BackwardAnalysisInputs change the field run_this_scattering_type = False and in ForwardAnalysisInputs change run_this_scattering_type = True
  • Click Run and check that the script runs without errors

Fixes #xxxx.

This allows backward and forward fitting to have their own fitting parameters.
Updated rest of files to reflect this change.
@GuiMacielPereira GuiMacielPereira linked an issue Jan 17, 2025 that may be closed by this pull request
@GuiMacielPereira GuiMacielPereira self-assigned this Jan 17, 2025
@GuiMacielPereira GuiMacielPereira added this to the v6.13 milestone Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vesuvio-analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate y-space fit inputs into two classes
1 participant