Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name the destination when announcing arrival #422

Closed
1ec5 opened this issue Jul 25, 2017 · 2 comments
Closed

Name the destination when announcing arrival #422

1ec5 opened this issue Jul 25, 2017 · 2 comments
Labels
feature New feature request. topic: instructions topic: search

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jul 25, 2017 •
edited
Loading

The voice announcement when arriving at a destination should use the waypoint’s name instead of “destination”, for consistency with the turn banner (#419). To implement this behavior, we could make RouteStep.name mutable (ick), or we could build a new RouteStep based on the current arrival RouteStep, but with the name replaced with the waypoint’s name.

/cc @bsudekum
@1ec5 1ec5 mentioned this issue Jul 27, 2017
Closed
@1ec5
Copy link
Contributor Author

1ec5 commented Jul 27, 2017

Tracking upstream in Project-OSRM/osrm-text-instructions#134.

@1ec5
Copy link
Contributor Author

1ec5 commented May 22, 2018

Forward-duping to #1123.

@1ec5 1ec5 closed this as completed May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature request. topic: instructions topic: search
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@1ec5