New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat Request: Allow more control over response type #407

Open

atomicpages opened this issue Dec 16, 2020 · 1 comment · May be fixed by #420

atomicpages commented Dec 16, 2020 •

edited

Loading

When fetching data from static image, it might be nice to give users more control over the response type. For example:

import mbClient from "@mapbox/mapbox-sdk";
import StaticImage from "@mapbox/mapbox-sdk/services/static";

const client = mbClient({accessToken: "..."});
const staticImageService = StaticImage(client);

staticImageService.getStaticImage({ ... })
  .send({ responseType: 'blob' })
  .then(res => {
    // do something with res
  });

I poked around the code and didn't find any way to override the response type. I'm happy to send a PR for this. LMK 👍

pedrofsantoscom added a commit to pedrofsantoscom/mapbox-sdk-js that referenced this issue


          fix mapbox#407

ca5e1ea

fix mapbox#407

pedrofsantoscom linked a pull request

that will close this issue

Open

pedrofsantoscom commented Jun 8, 2021

@andrewharvey Can you check this PR to fix this issue? #420
cc @atomicpages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment