MapTiler Access Token does not get added to URLs

[rsalzer]

I tried to use a JSON style in which MapTiler-Datasource are used. I left all the key={key} in there in order for Maputnik to replace it when I add it in the "Style Setting".

Unfortunately it does not apply them.

Steps to reproduce:

• Open this file in Maputnik (Open --> Upload):
  style.json
• Add a MapTiler Access Token to the "Style Settings"

[HarelM]

I would say that I hoped maptiler would be inclined to fix this, but they have their editor, so I'm not sure any help would come from there.
Having said that, maputnik codebase is small and you should be able to find and fix this issue.

[HarelM]

The code around replacing the access token is weird, and potentially buggy, or does not expect this flow.
Since the keys should be part of the style, I believe you should simply set them in the relevant source and not expect maputnik to replace it.

Bottom line, more of a feature than a bug :-)

[rsalzer]

Then the bottom line would be to remove those fields which suggest that it works ;)

A better flow would probably be to offer values which maputnik replaces ... {key} or {maptilerKey} and then replaces them everywhere.

[HarelM]

It works for glyphs and maybe sprites I believe.
But for sources there's a bunch of code that I didn't understand...

[rsalzer]

Probably it would be quite easy to add a possibility to add variables (in the shape of {variable}) which then can get replaced. Like this it would be universal ... I might add a PR

[birkskyum]

Can't we just keep the api keys in the urls instead of all this find/replace {key} complexity? It would have avoided entirely the need for e.g.:

• Fix insertion of access tokens, when swapping renderer #1021

@HarelM , that's what you mean here as well, right? I'll attempt to take out all the access_token handling.

[HarelM]

Yes, the glyphs, sprite and source URLs can be added as a full address including the access token and avoid all this complexity...

[birkskyum]

@HarelM , I realized it's maybe not great to only have the api keys in urls.. if you have a style locally with urls containing {key} and upload that to maputnik, it's necessary that Maputnik can insert the tokens, rather than expect some server to do it. Examples being:

• https://github.com/maputnik/osm-liberty
• https://github.com/openmaptiles/positron-gl-style/blob/master/style.json

[HarelM]

Ahh, I see... I don't have a good idea how to solve this from the top of my head, it might require more thought to think about a proper UX to solve this on one hand and easier maintenance on the other...
Or that simply there's a need to handle this differently in the code, maybe using transfrom url or something, IDK...