Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO support?! #99

Open
haexhub opened this issue Feb 27, 2020 · 6 comments
Open

SSO support?! #99

haexhub opened this issue Feb 27, 2020 · 6 comments

Comments

@haexhub
Copy link

haexhub commented Feb 27, 2020

Hi,

I tried your extension and found it quite suitable.
Are you planning to add sso support?

@marcellourbani
Copy link
Owner

Hi
I do but don't have a schedule or a SSO setup I can use save my cloud trial account (SAML basedI think)

Will probably have a go once I got autocompletion to work for CDS views ( #96)

@marcellourbani
Copy link
Owner

@haexhub
Just got oauth2 working :)
Not other forms of SSO for now
Hope it's good enough for you

@dellagustin-sap
Copy link

Hi @marcellourbani , since you closed the issue, I would like to ask: Are you not planning to implement SSO anymore?

should it not be kept open in case some contributor wants to?
If you have decided not to implement it, I suggest stating the reason (lack of time?) and mark with the label wont fix or something like that, so that the community knows.

Thanks for the awesome work!

@marcellourbani
Copy link
Owner

Hi @dellagustin-sap
I closed it because at least one flavour of SSO is supported.
Frankly I have no idea what others are used in the wild, how relatively popular they are, how to implement them with web technologies. And don't have a system to test them onto.
I guess SAML would be easy enough if I had a system to play with. Kerberos probably impossible without some external binary

If anyone wants to contribute fine.

@ShortCutNinja
Copy link

it would be great if SAML is supported

@marcellourbani
Copy link
Owner

my biggest issue implementing it is I don't have access to such a system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants