Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable using the chartjs subpackage separately #39

Closed
marianogappa opened this issue Aug 11, 2018 · 1 comment
Closed

Enable using the chartjs subpackage separately #39

marianogappa opened this issue Aug 11, 2018 · 1 comment

Comments

@marianogappa
Copy link
Owner

A wealth of use cases would be enabled if charts could be made programatically instead of using the CLI tool proper, e.g. #16

Required changes are minimal:

  • Calculating minFSS and maxFSS within the subpackage rather than receiving them
  • Producing the full HTML/JS/CSS should be parameterised and implemented within the subpackage
  • Examples, better godoc and a README in the subpackage
marianogappa pushed a commit that referenced this issue Aug 11, 2018
Isolates dataset in order to package it. #39
280b8c0
marianogappa pushed a commit that referenced this issue Aug 11, 2018
Fixes broken tests. #39
8404f1e
marianogappa pushed a commit that referenced this issue Aug 12, 2018
Calculates minFSS/maxFSS inside chart.js package. Adds comments. #39
6620955
marianogappa pushed a commit that referenced this issue Aug 19, 2018
Implements OutputMode and moves template content to chartjs package #39
47489c4
marianogappa pushed a commit that referenced this issue Aug 19, 2018
Adds docs #39
cd7c48f
marianogappa pushed a commit that referenced this issue Aug 19, 2018
Adds a few more comments. #39
7b34b79
@marianogappa
Copy link
Owner Author

Merged in #40.
Please review:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marianogappa