Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Max calls per sponsee is wrong #45

Open
aguillon opened this issue Jan 22, 2024 · 2 comments
Open

The Max calls per sponsee is wrong #45

aguillon opened this issue Jan 22, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@aguillon
Copy link
Collaborator

aguillon commented Jan 22, 2024

I hadn't realized that we had a different understanding of this condition. The goal is not to limit the number of calls for a specific sponsee (giving their address and so on). The goal is to limit the number of calls for new users, in order to sponsor only the first N calls for each user.

I believe this could be a good first issue too for someone else (cc @lykimq). What's your opinion @quentin-burg?

Make sure

  • to change the database scheme
  • to write a migration script
  • to check the conditions correctly in the API
  • that the UI is changed too, before merging on staging/ghostnet.
@aguillon aguillon added bug Something isn't working good first issue Good for newcomers labels Jan 22, 2024
@quentin-burg
Copy link
Collaborator

Yes agree ! :-)

@lykimq lykimq self-assigned this Jan 23, 2024
@lykimq
Copy link
Collaborator

lykimq commented Jan 23, 2024

I can onboard by working on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants