Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature Request for json support in CORB #96

Open
lsaishanker opened this issue Jun 2, 2019 · 5 comments
Open

New Feature Request for json support in CORB #96

lsaishanker opened this issue Jun 2, 2019 · 5 comments

Comments

@lsaishanker
Copy link

It will be nice if CORB can provide support to read and process input file in json format.
Thank you.

@hansenmc
Copy link
Member

hansenmc commented Jun 2, 2019

This would be easiest to implement with libraries, such as Jackson or GSON.

Might want to look into providing streaming JSON parser, in order to be able to parse extremely large files.

We would need a means of specifying what to select. XPath? And/or some dot notation substituting “.” for “/“ like JSONPath https://goessner.net/articles/JsonPath/?

@hansenmc
Copy link
Member

hansenmc commented Jun 2, 2019

If using dependencies, need to make sure it is user choice to bring implementation(like Jasypyt) or publish as a separate “plugin” jar.

@bbandlamudi
Copy link
Contributor

Jaspyt is dependency is done a little differently using reflection to avoid including jasypt.jar at build time. I am not sure if we can something similar to JSON, but I would assume reflection could get tricky as we might need a lot of classes to import. A separate plugin would be more practical I think.

@hansenmc
Copy link
Member

hansenmc commented Jun 2, 2019

I was thinking along the lines of setting any of those dependencies as provided or compileOnly. That way, we could build and bundle the classes, but it wouldn’t be included in the distro or the dependency chain. A user would need to ensure that those jars were on the classpath at runtime if they wanted to use those classes.

@bbandlamudi
Copy link
Contributor

I agree - as long as the users who don't use JSON streaming plugin aren't forced to include jaxb or gjson jars, we should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants