Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide example with react-admin v3 using the authorization code flow and PKCE #5

Open
RafBorrelli opened this issue Feb 11, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@RafBorrelli
Copy link

Could you please provide an example with react-admin v3 using the authorization code flow and PKCE?

Thank you.

@Kmaschta Kmaschta added the enhancement New feature or request label Feb 11, 2020
@Kmaschta
Copy link
Contributor

That would be great, indeed 👍
React Admin v3 has been released two months ago, it's time to update this example

@ichoriy
Copy link

ichoriy commented Mar 28, 2020

Thank you very much for this example, but also I would appreciate, if possible, the example could also support for both standard(username/password) + OAuth.

@wattry
Copy link

wattry commented Jun 5, 2020

We are using this in our implementation of Oauth and I figured why not be a good neighbour and share. Here is my fork, I still need some help debugging the "Please Login Error" but at least the flow is working and we can get access to the token.

Some of the API packages have been deprecated and/or move and the docs need some love. I'd love to help where I can if some other devs are willing to do a code review. Thanks in advance.

@wattry
Copy link

wattry commented Jun 11, 2020

I'm not sure if anyone is following this project, I was able to get OAuth working with React Admin V3. Google does not allow URL fragments (what creates the /#/ on the React Admin URL) thus createHashHistory used by default was creating a bug. This has been resolved by using createBrowserHistory.

We have not needed to implement PKCE yet, however, this pull request will allow you to use the authorization_code workflow in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants