From 00bc4fe6120aed8b387ba7603d2e4b22e7bebea7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Agust=C3=ADn=20M=C3=A9ndez?= Date: Fri, 9 Feb 2024 13:53:55 -0600 Subject: [PATCH 1/3] Making codespell hook able to modify files --- .pre-commit-config.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 9d1bf2d..ccb12c5 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -50,6 +50,8 @@ repos: rev: v2.2.6 hooks: - id: codespell + args: + - "--write-changes" - repo: https://github.com/asottile/pyupgrade rev: v3.15.0 From 5fbc03e32cb5f5914b82350326858ec043c19f40 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Agust=C3=ADn=20M=C3=A9ndez?= Date: Fri, 9 Feb 2024 13:54:11 -0600 Subject: [PATCH 2/3] Now we have 100% test coverage --- tests/test_forms.py | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tests/test_forms.py b/tests/test_forms.py index a430286..3120ea7 100644 --- a/tests/test_forms.py +++ b/tests/test_forms.py @@ -1,3 +1,5 @@ +from django.contrib.auth.models import User +from django.contrib.contenttypes.models import ContentType from django.test import TestCase from generic_links.forms import AddLinkForm @@ -5,7 +7,8 @@ class AddFormTest(TestCase): def setUp(self): - self.initial_kwargs = dict(user=None, object_id="1", content_type="1") + content_type = ContentType.objects.get_for_model(User) + self.initial_kwargs = dict(user=None, object_id=1, content_type=content_type) def test_add_form_without_data(self): form = AddLinkForm(**self.initial_kwargs) @@ -18,3 +21,12 @@ def test_add_form_with_incomplete_data(self): def test_add_form_with_complete_data(self): form = AddLinkForm(data={"url": "http://www.example.com", "title": "Example"}, **self.initial_kwargs) self.assertTrue(form.is_valid()) + + new_link = form.save() + print(new_link.content_object) + self.assertEqual(new_link.url, "http://www.example.com") + self.assertEqual(new_link.title, "Example") + self.assertEqual(new_link.user, None) + self.assertEqual(new_link.object_id, 1) + self.assertEqual(new_link.content_type_id, self.initial_kwargs["content_type"].id) + self.assertEqual(new_link.is_external, False) From 654cd21bebfbce4b354fa3b4e91764d5f2954408 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Agust=C3=ADn=20M=C3=A9ndez?= Date: Fri, 9 Feb 2024 15:16:01 -0600 Subject: [PATCH 3/3] Removed no longer used manage.py in root folder --- manage.py | 11 ----------- 1 file changed, 11 deletions(-) delete mode 100755 manage.py diff --git a/manage.py b/manage.py deleted file mode 100755 index de84059..0000000 --- a/manage.py +++ /dev/null @@ -1,11 +0,0 @@ -#!/usr/bin/env python -from __future__ import annotations - -import os -import sys - -if __name__ == "__main__": - os.environ.setdefault("DJANGO_SETTINGS_MODULE", "tests.settings") - from django.core.management import execute_from_command_line - - execute_from_command_line(sys.argv)