Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to directly support UTF8 texts #249

Open
Cccc-owo opened this issue Jan 1, 2024 · 5 comments
Open

Is it possible to directly support UTF8 texts #249

Cccc-owo opened this issue Jan 1, 2024 · 5 comments

Comments

@Cccc-owo
Copy link

Cccc-owo commented Jan 1, 2024

In EU4CHS, I noticed that the original project's TODO has such descriptions:


image


  • Support UTF8 texts without the need to encode the YAML file.
  • The in-game encoding is also UTF8, which allows any language to co-exist without the unreadable codes.

So would you consider implementing these features? It may also be helpful for #227.
Thx

@MerCuJerry
Copy link

MerCuJerry commented Mar 3, 2024

Its possible to directly support UTF8 files. I made a version at https://github.com/MerCuJerry/EU4dll/tree/develop , but still wip. I tested it using chinese localisation and seems working well.

@Cccc-owo
Copy link
Author

Cccc-owo commented Mar 4, 2024 via email

@MerCuJerry
Copy link

MerCuJerry commented Mar 4, 2024

Got it. Are there testing build so we could test it?

inside the repo`s actions

@Cccc-owo
Copy link
Author

Its possible to directly support UTF8 files. I made a version at https://github.com/MerCuJerry/EU4dll/tree/develop , but still wip. I tested it using chinese localisation and seems working well.

Looks good to me. It indeed works.
ed23695f626f52ceb2f2d129ff0dc925
However, running the game may still crash the game.

@MerCuJerry
Copy link

Looks good to me. It indeed works.
ed23695f626f52ceb2f2d129ff0dc925
However, running the game may still crash the game.

feel free to raise an issue on my repo and tell me how to reproduce this bug :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants