Support for view routes

matchory · Feb 7, 2021 · 3704526 · 3704526
1 parent 0d77546
commit 3704526
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/src/RouteCollecting/ResolvedRoute.php b/src/RouteCollecting/ResolvedRoute.php
@@ -5,6 +5,7 @@
 namespace Matchory\Herodot\RouteCollecting;
 
 use Illuminate\Routing\Route;
+use Illuminate\Routing\ViewController;
 use Illuminate\Support\Facades\File;
 use Matchory\Herodot\Interfaces\ResolvedRouteInterface;
 use ReflectionClass;
@@ -28,6 +29,11 @@ public function __construct(
     ) {
     }
 
+    public function isView(): bool
+    {
+        return $this->route->getController() === ViewController::class;
+    }
+
     /**
      * @inheritDoc
      */

diff --git a/src/RouteCollecting/RouteCollector.php b/src/RouteCollecting/RouteCollector.php
@@ -106,10 +106,6 @@ protected function hasValidAction(Route $route): bool
         /** @var class-string $controller */
         $controller = $route->getController();
 
-        if (is_a($controller, ViewController::class)) {
-            return false;
-        }
-
         if (is_a($controller, RedirectController::class)) {
             return false;
         }

diff --git a/src/RouteCollecting/RouteResolver.php b/src/RouteCollecting/RouteResolver.php
@@ -6,6 +6,7 @@
 
 use Closure;
 use Illuminate\Routing\Route;
+use Illuminate\Routing\ViewController;
 use JetBrains\PhpStorm\ArrayShape;
 use Matchory\Herodot\Contracts\RouteResolver as Contract;
 use Matchory\Herodot\Interfaces\ResolvedRouteInterface;