-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Filtered firstline #1396
Comments
I think, @Mat-Ge, you asking us to run the expression through the filter backwards?! That is, rather than insert the |
The approach I was hoping for was not well formulated, sorry for that. Since the firstline is an input that should look as similar as possible to the output, I would have imagined the process to go something like this:
It may be that implementing this process is disproportionately complicated and a question-based approach using JS is more promising. |
One of my personal goals for STACK was to gradually communicate to (my undergraduate) students the importance of using a syntax. In that context, the more a teacher uses a correct syntax, e.g. Actually, STACK does de-parse teacher's input quite a lot. E.g. changing things like So, for example, this is the point where a Basically, we'd have to provide more functionality at this point. It's a lot of work, and given my goals I'm not sure this really is a high priority for me in the short term, sorry! |
Many thanks for your work Chris! It seems, you have found a surprising clear and simple approach to solve this issue. It is my pleasure to close this issue. |
Thanks @Mat-Ge if you can send me some real examples (by email is fine) then I'll add them into the unit tests so that I remember these are examples of real behavior we need to preserve. |
In equivalence reasoning, the option firstline for the syntax hint is quite nice. Unfortunately, the expression is taken unformatted from the modal answer. Would it be trivial or complicated to run this expression through the same filters as the validated expression (especially for the insert stars)?
![Image](https://private-user-images.githubusercontent.com/128398586/413223348-038435b9-5592-4e36-bb70-69a0348d5ea2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5NzgxMDEsIm5iZiI6MTczOTk3NzgwMSwicGF0aCI6Ii8xMjgzOTg1ODYvNDEzMjIzMzQ4LTAzODQzNWI5LTU1OTItNGUzNi1iYjcwLTY5YTAzNDhkNWVhMi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxOVQxNTEwMDFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wZGQ5NTQ4ODJhMGQwOWUyYjU0N2E4N2NhODEzYTBiN2E5OGI3OTA1ZGJhMDVkN2YzZWQyNGZmNGE1ZjJhZTFkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.UYXo4LfwCrKwiYsDhalFyUQvwcy-YUHG0MnV3fOabd0)
Example: Here, the expression is barely readable due to the many stars, in contrast to the validated expression.
If the expression was created with simp=false (e.g. so that the expression is arranged as desired), then unnecessary brackets are also visible, which are also filtered out in the validated expression.
![Image](https://private-user-images.githubusercontent.com/128398586/413223457-a90d46f0-42bc-4521-90e7-bd5d34dd140a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5NzgxMDEsIm5iZiI6MTczOTk3NzgwMSwicGF0aCI6Ii8xMjgzOTg1ODYvNDEzMjIzNDU3LWE5MGQ0NmYwLTQyYmMtNDUyMS05MGU3LWJkNWQzNGRkMTQwYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxOVQxNTEwMDFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02OTE1ZWI1MDI1NWIyNWVlMWJiNjUxN2QyN2RjNmE4NmFkMzVkNmFhY2I5OTQ1OTRkZWQ0MjRmZTM5OTc0MWIwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.s-vnMLC8GvtmOADQLTZFow31bEXsORCkRTuy4UCWPOc)
The text was updated successfully, but these errors were encountered: