Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server incorrectly responds with 200 OK to reaction removal, but takes hours to actually remove the reaction. #2553

Open
RokeJulianLockhart opened this issue Nov 6, 2024 · 0 comments
Labels
meta Things that are foundation related or external services mentioning matrix that need changes

Comments

@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Nov 6, 2024

Errata

As element-hq/element-web#28249 (comment) explains, the effect for the user is as the undermentioned describes:

Unable to remove reactions from messages after page refresh.

Steps to reproduce

  1. Uploaded an MP4 H265 video file to https://matrix.to/#/!LdFTpgksHpQBBtjOMN:matrix.org/$7z9qoF17VHc08wg2mlG1fRYtfhXbHmhxp-ZNQCXcK-o?via=matrix.org&via=beeper.com.

  2. Reacted with an emoji.

  3. Attempted to remove the reaction.

    Outcome

    What did you expect?

    I should have been able to.

    What happened instead?

    I was able to.

  4. Refreshed the page.

  5. Attempted to remove the reaction.

    Outcome

    What did you expect?

    I should have been able to.

    What happened instead?

    I was unable to remove it, yet was able to remove others added subsequently:

    2024-10-20.12-56-42.mp4

Operating system

https://download.fedoraproject.org/pub/fedora/linux/releases/40/Spins/x86_64/iso/Fedora-KDE-Live-x86_64-40-1.14.iso

Browser information

https://fedora.pkgs.org/40/fedora-updates-x86_64/firefox-131.0.3-1.fc40.x86_64.rpm.html

URL for webapp

https://develop.element.io/#/room/!LdFTpgksHpQBBtjOMN:matrix.org

Application version

Element version: 249c0fd1df0a-js-88cf5eb76983
Crypto version: Rust SDK 0.7.2 (517d99b), Vodozemac 0.7.0

Homeserver

https://matrix.org/

Will you send logs?

Yes

However, what is actually occurring is the server is informing the client that its request for reaction removal is successful, despite the server taking up to multiple hours to actually remove the reaction. This is erroneous.

Meta

  1. I have reported this to @matrix-org per Unable to remove reactions from messages after page refresh. element-hq/element-web#28249 (comment) - a recommendation to do so by a developer of the Element client:

    The server says the redaction is successful with a 200 OK, so is not something a client can reliably detect or deal with.

    I suggest that you read the thread. It is adequately concise, and explains better than I can summarise.

  2. I have reported this at this repository because https://github.com/orgs/matrix-org/repositories?type=source&q=server didn't return any better results in +2024-11-06.

@RokeJulianLockhart RokeJulianLockhart changed the title Unable to remove reactions from messages. Server incorrectly responds with 200 OK to reaction removal, but takes hours to actually remove the reaction. Nov 6, 2024
@MTRNord MTRNord added the meta Things that are foundation related or external services mentioning matrix that need changes label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Things that are foundation related or external services mentioning matrix that need changes
Projects
None yet
Development

No branches or pull requests

2 participants