Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

001-spotify.10s.sh: Like indicator #1861

Open
martin-braun opened this issue Sep 16, 2022 · 3 comments
Open

001-spotify.10s.sh: Like indicator #1861

martin-braun opened this issue Sep 16, 2022 · 3 comments
Labels

Comments

@martin-braun
Copy link
Contributor

Ellow @jtokoph @m-cat @benjifs, love this plugin, but I have a suggestion to improve it.

I often listen to Spotify Radio of my playlists to discover new music. It would help to see a heart icon on the right of the current track name in the top menu to see if the current track is already added to my liked tracks or not.

So, if I hear a tune I like, I don't have to switch to Spotify just to check if I have this track in my library already.

Thanks!

@benjifs
Copy link
Contributor

benjifs commented Sep 17, 2022

I really like this idea however I'm facing two issues with it.

Showing the ⭐ or ❤️ icons next to the title make things look a bit cluttered. I can also add it to the info box that shows when you click on the title but that may be a click to many.

The way to get this info for Spotify would be using the following:

osascript -e 'tell application "Spotify" to starred of current track' 

However, I'm getting the following error:

30:37: execution error: Spotify got an error: AppleEvent handler failed. (-10000)

Can someone else confirm whether they are also seeing this? All the other commands seem to work fine so I'm wondering whether its something broken for everyone or just me

@martin-braun
Copy link
Contributor Author

martin-braun commented Sep 20, 2022

@benjifs I'm glad you like my idea. I have no solution for the current issue with it, but I want to suggest to put the heart to the left instead? Or maybe animated between play and heart icon while playing? I'm often in Vim and thus avoid the usage or a mouse or trackpad, so clicking would interrupt my flow.

If there is no good solution, your suggested compromise would be alright, I could alter the script to show the heart in the top bar myself.

@benjifs
Copy link
Contributor

benjifs commented Sep 22, 2022

@martin-braun I have a version of the spotify script that I modified to work with both Spotify and Apple Music. I have added the icon for liked songs on there and it works with Apple Music but I'm still seeing the error from above for Spotify so I can't get the "liked" status of a song. Can you confirm whether you also have that issue?

If not, I can just assume something is wrong with my machine. I can then just push the changes needed to show the liked status if its works for you. I don't use Spotify anymore which is why I modified this script to use Apple Music.

Here's how its looking now though:
xbar showing spotify script running with liked status added to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants