Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Combine GPU and simple Scaler into single Scaler #3621

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

yorik
Copy link
Contributor

@yorik yorik commented Feb 18, 2025

What ❔

Combine GPU and simple Scaler into single Scaler
Move code which interacts with other part into manager.rs.
Created Key trait and GpuKey and NoKey implementations.
Changed Scaler config.

Why ❔

To reduce copy of the almost the same code and number of bugs.

Is this a breaking change?

  • Yes
  • No

Operational changes

Requires following config change:

  • Add into scaler_targets prover config like this:
  scaler_targets:
    - queue_report_field: prover_jobs
      deployment: circuit-prover-gpu
      min_replicas: 0
      max_replicas:
        cluster-foo:
          L4: 100
          T4: 200
        cluster-bar:
          L4: 100
          T4: 200
      speed:
        L4: 1500
        T4: 700
  • Remove min_provers, max_provers, prover_speed.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

ref ZKD-2229

Move code which interacts with other part into manager.rs.
Created Key trait and GpuKey and NoKey implementations.
Changed Scaler config.

ref ZKD-2229
@yorik yorik marked this pull request as draft February 19, 2025 08:25
@yorik yorik changed the title TODO refactor: Combine GPU and simple Scaler into single Scaler refactor: Combine GPU and simple Scaler into single Scaler Feb 19, 2025
@yorik yorik changed the title refactor: Combine GPU and simple Scaler into single Scaler refactor!: Combine GPU and simple Scaler into single Scaler Feb 19, 2025
@yorik yorik marked this pull request as ready for review February 20, 2025 16:08
@yorik yorik enabled auto-merge February 20, 2025 16:09
@yorik yorik requested a review from EmilLuta February 25, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant