You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Have a use-case currently where I need to use the same ScreenshotParams to handle screenshots for multiple pages in different branches. As it stands, I need to re-declare the params for each branch as fn screenshot moves ScreenshotParams. Quick-fix would be to derive Clone, and alternatively we could avoid consuming the screenshot params. Wanted to get some feedback here, if so I can open a PR with the preferred approach.
Also, thank you for the great library! Using it to power some parts of Have I Been Squatted.
The text was updated successfully, but these errors were encountered:
Have a use-case currently where I need to use the same
ScreenshotParams
to handle screenshots for multiple pages in different branches. As it stands, I need to re-declare the params for each branch asfn screenshot
movesScreenshotParams
. Quick-fix would be to deriveClone
, and alternatively we could avoid consuming the screenshot params. Wanted to get some feedback here, if so I can open a PR with the preferred approach.Also, thank you for the great library! Using it to power some parts of Have I Been Squatted.
The text was updated successfully, but these errors were encountered: