Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Make ScreenshotParams clone-able or pass by ref #253

Open
JuxhinDB opened this issue Jan 19, 2025 · 1 comment
Open

Question: Make ScreenshotParams clone-able or pass by ref #253

JuxhinDB opened this issue Jan 19, 2025 · 1 comment

Comments

@JuxhinDB
Copy link

JuxhinDB commented Jan 19, 2025

Have a use-case currently where I need to use the same ScreenshotParams to handle screenshots for multiple pages in different branches. As it stands, I need to re-declare the params for each branch as fn screenshot moves ScreenshotParams. Quick-fix would be to derive Clone, and alternatively we could avoid consuming the screenshot params. Wanted to get some feedback here, if so I can open a PR with the preferred approach.

Also, thank you for the great library! Using it to power some parts of Have I Been Squatted.

@mattsse
Copy link
Owner

mattsse commented Jan 20, 2025

sounds reasonable to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants