-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dsine Surface Normal Option #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add dsine surface normal add normal comparison visualization update pixi.toml include geffnet dependancy for dsine Add surface normal comparison visualization add icecream dep to pixi and caching for pip install -e add normal metrics/images to get_img_metrics fix pyproject bug Update pixi.toml with new dependencies and outputs cache add coordinate system conversion for DSINE normal network add function to generate pointcloud for polycam data processed by ns-process-data add train polycam command to pixi Update pixi.toml with gcc and gxx Update pixi.toml with Quick Run example and other training examples
pointed link to correct repo
Support python 3.8 and update readme with instructions
Hi ! 👋🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option to use the DSINE surface normal estimator
To test out, just run
This will
Heres an example of a custom dataset I collected

DSINE predicts normals in a range of -1 to 1 in camera coordinate system LUB (+X left | +Y up | +Z Back), I convert them to RUB.
I left the current convention names as they are but they appear to be backwards (no issues with functionality, just naming convention errors #9
get_image_metrics_and_images