Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log download is CPU bound on UI thread #4656

Open
NaterGator opened this issue Feb 28, 2017 · 0 comments · May be fixed by #11980
Open

Log download is CPU bound on UI thread #4656

NaterGator opened this issue Feb 28, 2017 · 0 comments · May be fixed by #11980
Assignees
@HTRamsey

Comments

@NaterGator
Copy link
Contributor

NaterGator commented Feb 28, 2017 •
edited by thomasgubler
Loading

I've noticed that some systems manage to consistently saturate USB HS bandwidth when downloading logs while others struggle to utilize 1/3rd of the available bandwidth. Some cursory digging leads me to believe this is a performance issue with performing mavlink decoding and log download on the UI thread.

We should rework the LogDownloadController to handle the actual download process on a worker thread, and consider the scope of work to move communications and mavlink parsing onto a worker thread as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HTRamsey HTRamsey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AnalyzeView: Download Logs in Separate Thread HTRamsey/qgroundcontrol
2 participants
@NaterGator @HTRamsey