Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Working with Jekyll CommonMark #43

Open
xplosionmind opened this issue Jan 9, 2021 · 4 comments
Open

Not Working with Jekyll CommonMark #43

xplosionmind opened this issue Jan 9, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@xplosionmind
Copy link

The bi-directional links generator doesn't parse links when jekyll-commonmark is used.

@meewgumi
Copy link
Contributor

Hi @xplosionmind, I switched to Commonmark and it's working for me. Hope this helps:

I used the Github Pages version because it supports Github Flavored Markdown, which helps keep things consistent with the formatting. Plus it enables Github-flavored tables and works with Obsidian!

@maximevaillancourt
Copy link
Owner

Thanks folks. What do we think about switching the template to Commonmark by default? This way it would offer a standardized experience for the majority of use cases.

@maximevaillancourt maximevaillancourt added the bug Something isn't working label May 31, 2021
@meewgumi
Copy link
Contributor

@maximevaillancourt I like Commonmark for most cases, but I found one interesting drawback: You can no longer use {: .internal-link} notation to add classes or IDs. It looks like this is a Kramdown feature. It doesn't bother me too much since I'm OK switching to HTML classes for this use case.. but if someone has a lot of these links in their site they'll have to go manually update them after fetching upstream

@xplosionmind
Copy link
Author

The main issue presented by Commonmark, in my opinion, is definitely the lack of auto-generation of ids for headings.

See this related issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants