Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some creatures AoN link is broken as it leads to /Monsters.aspx instead of /NPCs.aspx #56

Open
baqterya opened this issue Dec 5, 2023 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@baqterya
Copy link

baqterya commented Dec 5, 2023

For example:
Link of bandit leads to https://2e.aonprd.com/Monsters.aspx?ID=887 which results in an error
Instead it should lead to https://2e.aonprd.com/NPCs.aspx?ID=887

Zrzut ekranu 2023-12-06 002807

@maxiride maxiride added the bug Something isn't working label Jul 30, 2024
@maxiride
Copy link
Owner

Line to be fixed

window.open("https://2e.aonprd.com/Monsters.aspx?ID=" + row.id, "_blank");

@maxiride
Copy link
Owner

maxiride commented Feb 4, 2025

Creatures are now split between Monsters and NPCs. So the URL cannot be built by concatenating only the ID, each item must carry over if it's a Monster or an NPC.

AS-IS
Creatures are all linked to Monsters.aspx.

TO-BE
Depending on the creature type build the URL differently to split NPCs and Monsters

@maxiride maxiride added this to the v2 milestone Feb 4, 2025
maxiride added a commit that referenced this issue Feb 18, 2025
Closes: #53, #48, #56

Upgraded Quasar and Vue, added Pinia integration.
Moved all encounter logic to dedicated Pinia store and simplified some business logic.

Adapted tables and objects to new AoN JSON dump obtainable directly from their website.

Added new menu buttons for support, donation and release info (to be reviewed further).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants