Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ET.py check file existence #97

Open
thomasmanke opened this issue Oct 27, 2024 · 3 comments
Open

ET.py check file existence #97

thomasmanke opened this issue Oct 27, 2024 · 3 comments

Comments

@thomasmanke
Copy link
Contributor

ET.py should assert existence of files and exist more gracefully if missing.
Use case: multiqc_samtools_flagstat.txt is not produced by multiQC 1.23
Suggestion: replace rates with NaN if undetermined?

@adRn-s
Copy link
Member

adRn-s commented Oct 28, 2024

Maybe there was another issue here and BRB needs to reprocess the whole thing. I would be surprised if their samtools module doesn't write the text file somewhere and then parse it.

PS. Actually, I went through MultiQC's changelog and their only stated changes were not related to moving the file or anything... I know, it doesn't prove anything. The change could've been done and not written.... but still,

1.23

The samtools flagstat test that verifies some logic in the flagstat submodule of the samtools module;

1.22

Add violin multiple datasets & samtools flagstat percentage switch (MultiQC/MultiQC#2430)

@thomasmanke
Copy link
Contributor Author

I was also surprised, but I had explicitly tried (outside of BRB) all multiQC from snapePipe3.0.0 env (1.19), snakePipe3.1.0 (1.23) and 1.25 (per module load). Only 1.23 did not produce the multiqc_samtools_flagstat.txt file.

@WardDeb
Copy link
Member

WardDeb commented Oct 29, 2024

cfr. maxplanck-ie/snakepipes#1074
Note that this doesn't fix the need for a more 'graceful exit', which'd make this whole thing more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants