From f1365dcba63621945978df0a39e3ec120688a8aa Mon Sep 17 00:00:00 2001 From: Robbie Sundstrom Date: Fri, 13 Dec 2024 08:21:41 -0500 Subject: [PATCH 1/3] Changing what I believe are necessary lines --- lib/content/audio/no_service.ex | 2 +- lib/content/message/alert/use_routes.ex | 2 +- test/signs/realtime_test.exs | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/content/audio/no_service.ex b/lib/content/audio/no_service.ex index 01b851bc5..3708a22ca 100644 --- a/lib/content/audio/no_service.ex +++ b/lib/content/audio/no_service.ex @@ -89,7 +89,7 @@ defmodule Content.Audio.NoService do cond do use_shuttle? -> " Use shuttle." # Hardcoded for Union Square - use_routes? -> " Use routes 86, 87, or 91" + use_routes? -> " Use routes 87, 91 or 109" true -> "" end diff --git a/lib/content/message/alert/use_routes.ex b/lib/content/message/alert/use_routes.ex index b1d4f2752..398caf755 100644 --- a/lib/content/message/alert/use_routes.ex +++ b/lib/content/message/alert/use_routes.ex @@ -9,7 +9,7 @@ defmodule Content.Message.Alert.UseRoutes do defimpl Content.Message do def to_string(_) do - "Use Routes 86, 87, or 91" + "Use routes 87, 91 or 109" end end end diff --git a/test/signs/realtime_test.exs b/test/signs/realtime_test.exs index 8c5dcab76..bf3cc7191 100644 --- a/test/signs/realtime_test.exs +++ b/test/signs/realtime_test.exs @@ -1622,10 +1622,10 @@ defmodule Signs.RealtimeTest do text_zone: "x" } - expect_messages({"No Southbound svc", "Use Routes 86, 87, or 91"}) + expect_messages({"No Southbound svc", "Use routes 87, 91 or 109"}) - expect_audios([{:ad_hoc, {"No Southbound service. Use routes 86, 87, or 91", :audio}}], [ - {"No Southbound service. Use routes 86, 87, or 91", nil} + expect_audios([{:ad_hoc, {"No Southbound service. Use routes 87, 91 or 109", :audio}}], [ + {"No Southbound service. Use routes 87, 91 or 109", nil} ]) Signs.Realtime.handle_info(:run_loop, sign) From 8da47506da326ac65bd9d86369fc144713db9b35 Mon Sep 17 00:00:00 2001 From: Robbie Sundstrom Date: Fri, 13 Dec 2024 10:15:03 -0500 Subject: [PATCH 2/3] capitalize routes --- lib/content/audio/no_service.ex | 2 +- lib/content/message/alert/use_routes.ex | 2 +- test/signs/realtime_test.exs | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/content/audio/no_service.ex b/lib/content/audio/no_service.ex index 3708a22ca..d5bf881a9 100644 --- a/lib/content/audio/no_service.ex +++ b/lib/content/audio/no_service.ex @@ -89,7 +89,7 @@ defmodule Content.Audio.NoService do cond do use_shuttle? -> " Use shuttle." # Hardcoded for Union Square - use_routes? -> " Use routes 87, 91 or 109" + use_routes? -> " Use Routes 87, 91 or 109" true -> "" end diff --git a/lib/content/message/alert/use_routes.ex b/lib/content/message/alert/use_routes.ex index 398caf755..d8b18b09c 100644 --- a/lib/content/message/alert/use_routes.ex +++ b/lib/content/message/alert/use_routes.ex @@ -9,7 +9,7 @@ defmodule Content.Message.Alert.UseRoutes do defimpl Content.Message do def to_string(_) do - "Use routes 87, 91 or 109" + "Use Routes 87, 91 or 109" end end end diff --git a/test/signs/realtime_test.exs b/test/signs/realtime_test.exs index bf3cc7191..de275dbae 100644 --- a/test/signs/realtime_test.exs +++ b/test/signs/realtime_test.exs @@ -1622,10 +1622,10 @@ defmodule Signs.RealtimeTest do text_zone: "x" } - expect_messages({"No Southbound svc", "Use routes 87, 91 or 109"}) + expect_messages({"No Southbound svc", "Use Routes 87, 91 or 109"}) - expect_audios([{:ad_hoc, {"No Southbound service. Use routes 87, 91 or 109", :audio}}], [ - {"No Southbound service. Use routes 87, 91 or 109", nil} + expect_audios([{:ad_hoc, {"No Southbound service. Use Routes 87, 91 or 109", :audio}}], [ + {"No Southbound service. Use Routes 87, 91 or 109", nil} ]) Signs.Realtime.handle_info(:run_loop, sign) From f0d594217303889a1967ca29020bd5b8c3c35b70 Mon Sep 17 00:00:00 2001 From: Robbie Sundstrom Date: Fri, 13 Dec 2024 12:14:23 -0500 Subject: [PATCH 3/3] Add oxford comma back for audio --- lib/content/audio/no_service.ex | 2 +- test/signs/realtime_test.exs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/content/audio/no_service.ex b/lib/content/audio/no_service.ex index d5bf881a9..63dcb4958 100644 --- a/lib/content/audio/no_service.ex +++ b/lib/content/audio/no_service.ex @@ -89,7 +89,7 @@ defmodule Content.Audio.NoService do cond do use_shuttle? -> " Use shuttle." # Hardcoded for Union Square - use_routes? -> " Use Routes 87, 91 or 109" + use_routes? -> " Use Routes 87, 91, or 109" true -> "" end diff --git a/test/signs/realtime_test.exs b/test/signs/realtime_test.exs index de275dbae..508ee768c 100644 --- a/test/signs/realtime_test.exs +++ b/test/signs/realtime_test.exs @@ -1624,8 +1624,8 @@ defmodule Signs.RealtimeTest do expect_messages({"No Southbound svc", "Use Routes 87, 91 or 109"}) - expect_audios([{:ad_hoc, {"No Southbound service. Use Routes 87, 91 or 109", :audio}}], [ - {"No Southbound service. Use Routes 87, 91 or 109", nil} + expect_audios([{:ad_hoc, {"No Southbound service. Use Routes 87, 91, or 109", :audio}}], [ + {"No Southbound service. Use Routes 87, 91, or 109", nil} ]) Signs.Realtime.handle_info(:run_loop, sign)