Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve tests #10

Open
mdb opened this issue Nov 4, 2022 · 1 comment
Open

improve tests #10

mdb opened this issue Nov 4, 2022 · 1 comment

Comments

@mdb
Copy link
Owner

mdb commented Nov 4, 2022 •
edited
Loading

At a minimum, it would be useful if the tests verified the correct POST body is sent during HTTP transactions with the GH API; the current tests overlook this detail.

Other improvement options include:

  • testing code coverage holes (viewable via go tool cover -html=coverage.out)
  • improvements to the acceptance tests' verification of expected output
@mdb
Copy link
Owner Author

mdb commented Nov 21, 2022

it would be useful if the tests verified the correct POST body is sent during HTTP transactions with the GH API

✅ This is now complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdb