Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - List ordering reverts itself #5010

Open
6 tasks done
matthewkdies opened this issue Feb 3, 2025 · 3 comments
Open
6 tasks done

[BUG] - List ordering reverts itself #5010

matthewkdies opened this issue Feb 3, 2025 · 3 comments
Labels
bug: confirmed bug Something isn't working

Comments

@matthewkdies
Copy link

First Check

  • This is not a feature request.
  • I added a very descriptive title to this issue (title field is above this).
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

When ordering items within a shopping list, the moved item will remain in the desired spot for less than a second and then revert to the original spot. Below is a recording from the Mealie demo site of the issue, which is also present in my hosted site as well:

Screen.Recording.2025-02-03.at.11.55.53.AM.mov

This occurs with label sort enabled and disabled.

Steps to Reproduce

  1. Add multiple items to a shopping list
  2. Re-order items on the list
  3. See order revert

Please provide relevant logs

INFO     2025-02-03T12:00:55 - [192.168.1.32:0] 200 OK "PUT /api/households/shopping/items HTTP/1.1"
INFO     2025-02-03T12:00:55 - [192.168.1.32:0] 200 OK "GET /api/households/shopping/lists/9bc47529-98da-4d99-953d-139380f61efc HTTP/1.1"
INFO     2025-02-03T12:00:59 - [192.168.1.32:0] 200 OK "GET /api/households/shopping/lists/9bc47529-98da-4d99-953d-139380f61efc HTTP/1.1"
INFO     2025-02-03T12:01:04 - [192.168.1.32:0] 200 OK "GET /api/households/shopping/lists/9bc47529-98da-4d99-953d-139380f61efc HTTP/1.1"

The PUT is immediately followed by a GET, but then there are subsequent GET requests as well. I'm not sure of their origin, as I wasn't refreshing the page or interacting with it beyond a singular item ordering.

Mealie Version

Version: develop (though it's practically 2.5.0, I've built a custom image using 2.5.0 to resolve this issue)
Build: N/A (not shown)

Deployment

Docker (Linux)

Additional Deployment Details

No response

@matthewkdies matthewkdies added bug Something isn't working triage labels Feb 3, 2025
@matthewkdies
Copy link
Author

When ordering via a PWA on my iPhone, the ordering remains and it respected. The failure occurs for me when I use my browser (Firefox) on any of the Mealie sites I have access to, meaning my site and the demo site.

@Kuchenpirat
Copy link
Collaborator

Hi, thanks for reporting this. I can recreate it, but only on firefox

@matthewkdies
Copy link
Author

Interesting... I have automatic Firefox updates enabled, I wonder if recent update may have affected this? I can try looking at some release notes (or downgrade) to see if there is a change that may have caused this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: confirmed bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants