diff --git a/mealie/repos/repository_generic.py b/mealie/repos/repository_generic.py index 75a447c4298..026cbb6c251 100644 --- a/mealie/repos/repository_generic.py +++ b/mealie/repos/repository_generic.py @@ -80,33 +80,18 @@ def get_all( limit: int | None = None, order_by: str | None = None, order_descending: bool = True, - start=0, override=None, ) -> list[Schema]: - self.logger.warning('"get_all" method is deprecated; use "page_all" instead') - - # sourcery skip: remove-unnecessary-cast - eff_schema = override or self.schema - - fltr = self._filter_builder() - - q = self._query(override_schema=eff_schema).filter_by(**fltr) - - if order_by: - try: - order_attr = getattr(self.model, str(order_by)) - if order_descending: - order_attr = order_attr.desc() - - else: - order_attr = order_attr.asc() + pq = PaginationQuery( + per_page=limit or -1, + order_by=order_by, + order_direction=OrderDirection.desc if order_descending else OrderDirection.asc, + page=1, + ) - q = q.order_by(order_attr) + results = self.page_all(pq, override=override) - except AttributeError: - self.logger.info(f'Attempted to sort by unknown sort property "{order_by}"; ignoring') - result = self.session.execute(q.offset(start).limit(limit)).unique().scalars().all() - return [eff_schema.model_validate(x) for x in result] + return results.items def multi_query( self,