Skip to content
This repository has been archived by the owner on Feb 3, 2022. It is now read-only.

Fail during backupMove() doesn't throw exception #55

Open
adam-paterson opened this issue Feb 26, 2018 · 2 comments
Open

Fail during backupMove() doesn't throw exception #55

adam-paterson opened this issue Feb 26, 2018 · 2 comments

Comments

@adam-paterson
Copy link
Contributor

rename() can fail fail on line GetCommand.php:229 and there is no error handling for this method.

screen_shot_2018-02-26_at_13_05_35

@punkstar
Copy link
Contributor

Need to check that the destination is writable before anything starts too.

@bobbyshaw
Copy link
Member

It currently checks the directory is writable but we should update that check to be specifically checking the file path is writable and that we catch the error 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants