Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track down every piece of code that could hang because of a KeyboardInterrupt #43

Open
Yomguithereal opened this issue Apr 23, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@Yomguithereal
Copy link
Member

And edit the startup hook to make threads die before waiting barrier, or break the barrier

@Yomguithereal Yomguithereal added the bug Something isn't working label Apr 23, 2021
Yomguithereal added a commit that referenced this issue Apr 24, 2021
Yomguithereal added a commit that referenced this issue Apr 24, 2021
Yomguithereal added a commit that referenced this issue Apr 24, 2021
@Yomguithereal
Copy link
Member Author

We still have an error possible when booting the dispatcher and when join the threads in exit

@Yomguithereal
Copy link
Member Author

Maybe state also needs to release condition on imap cleanup.

@Yomguithereal Yomguithereal changed the title Wrap threads start in finally shutdown Track down every piece of code that could hang because of a KeyboardInterrupt Apr 24, 2021
@Yomguithereal
Copy link
Member Author

raise KeyboardInterrupt in cleanup and shutdown

@Yomguithereal
Copy link
Member Author

Yomguithereal commented Apr 25, 2021

Basically the issue is this one: https://stackoverflow.com/questions/18637048/avoid-exception-ignored-in-python-enhanced-generator when a KeyboardInterrupt is fire in the cleanup phase (finally in the output generator or the __exit__ teardown).

@Yomguithereal
Copy link
Member Author

Also see PEP419: https://www.python.org/dev/peps/pep-0419/

@Yomguithereal
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant