Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Adding typescript #1

Open
mikesol opened this issue Feb 11, 2020 · 5 comments
Open

Adding typescript #1

mikesol opened this issue Feb 11, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@mikesol
Copy link

mikesol commented Feb 11, 2020

I haven't done a not-typescript project in forever, and I find that migration is super painful, so if things can start off typescript and there's not a compelling reason not to, I usually am in favor of that. Unless of course you are anti-typescript - I know at least one dev that thinks typing in javascript, in general, is not that useful and good tests are enough. @k4m4 what do you think?

@k4m4
Copy link
Contributor

k4m4 commented Feb 11, 2020

Yup, I don't see a reason not too. I will start by familiarizing myself more with TypeScript and will start migrating the existing code asap.

@mikesol
Copy link
Author

mikesol commented Feb 13, 2020

The most important thing is to launch - the nice thing about typescript is that you can have a mixed tsc/js library and migrate over time. I find that TS migrations and refactoring in general are good to do right after major events (ie launches) during the 1-2 days that you are collecting feedback.

@k4m4
Copy link
Contributor

k4m4 commented Feb 13, 2020

Sounds good. Will prioritize launch, then, and aim to migrate to TS later on.

@mikesol
Copy link
Author

mikesol commented Feb 13, 2020

Cool! Let me know if I can help with launch!

@k4m4
Copy link
Contributor

k4m4 commented Feb 13, 2020

Will do!

@k4m4 k4m4 added the enhancement New feature or request label Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants