Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename root module to Meilisearch instead of MeiliSearch #347

Open
ellnix opened this issue Feb 29, 2024 · 6 comments · May be fixed by #384
Open

Rename root module to Meilisearch instead of MeiliSearch #347

ellnix opened this issue Feb 29, 2024 · 6 comments · May be fixed by #384
Labels
breaking-change The related changes are breaking for the users
Milestone

Comments

@ellnix
Copy link
Collaborator

ellnix commented Feb 29, 2024

Also, if you have time you could put in your big breaking changing the main class name to Meilisearch instead of MeiliSearch. Not only here but in the ruby gem as well.

Originally posted by @brunoocasali in #344 (comment)

Also attempt to maintain backwards compatibility, with a warning for usage of MeiliSearch.

@ellnix ellnix changed the title Rename root module to Meilisearch insteaf of MeiliSearch Rename root module to Meilisearch instead of MeiliSearch Feb 29, 2024
@ellnix ellnix added the breaking-change The related changes are breaking for the users label Feb 29, 2024
@ellnix ellnix added this to the 0.13 milestone Feb 29, 2024
@jason-hobbs
Copy link
Contributor

I am starting to get the deprecation warning: WARN -- : [meilisearch-ruby] The top-level module of Meilisearch has been renamed.
[meilisearch-ruby] Please update "MeiliSearch" to "Meilisearch".

@ellnix
Copy link
Collaborator Author

ellnix commented Jan 14, 2025

I am starting to get the deprecation warning: WARN -- : [meilisearch-ruby] The top-level module of Meilisearch has been renamed. [meilisearch-ruby] Please update "MeiliSearch" to "Meilisearch".

Do you happen to have meilisearch-ruby in your Gemfile? It shouldn't normally pull 0.30.

@ellnix
Copy link
Collaborator Author

ellnix commented Jan 15, 2025

@jason-hobbs I fixed the version constraint, this warning should not appear if you use the just-released 0.14.2.

Please let me know if it worked.

@ansonhoyt
Copy link

Worked for me, though bundle update meilisearch-rails wouldn't upgrade from 0.14.1 to 0.14.2 until I manually cleared this from my Gemfile.lock:

    meilisearch (0.30.0)
      httparty (~> 0.17)

@ellnix
Copy link
Collaborator Author

ellnix commented Jan 15, 2025

Worked for me, though bundle update meilisearch-rails wouldn't upgrade from 0.14.1 to 0.14.2 until I manually cleared this from my Gemfile.lock:

    meilisearch (0.30.0)
      httparty (~> 0.17)

Seems understandable, it's a very strange situation we are in. I can only hope that anyone on 0.14.1 has meilisearch-ruby locked already, and ones who do not will get 0.14.2... 🫤

@jason-hobbs
Copy link
Contributor

Yes that worked for me. I locked the version, did a bundle install and it stated:
Fetching meilisearch 0.28.4 (was 0.30.0)
Installing meilisearch 0.28.4 (was 0.30.0)
Fetching meilisearch-rails 0.14.2 (was 0.14.1)
Installing meilisearch-rails 0.14.2 (was 0.14.1)
Bundle complete! 66 Gemfile dependencies, 190 gems now installed.
Use bundle info [gemname] to see where a bundled gem is installed.

Warning went away. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants