Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when paginating with will_paginate and Meilisearch is disabled #382

Open
ellnix opened this issue Jan 13, 2025 · 0 comments · May be fixed by #383 or #385
Open

Error when paginating with will_paginate and Meilisearch is disabled #382

ellnix opened this issue Jan 13, 2025 · 0 comments · May be fixed by #383 or #385

Comments

@ellnix
Copy link
Collaborator

ellnix commented Jan 13, 2025

Inspired by #375 I decided to try and see if the same issue applies to will_paginate:

  1) Pagination with will_paginate does not crash when meilisearch is disabled
     Failure/Error:
       expect do
         Movie.search ''
       end.not_to raise_error
     
       expected no Exception, got #<TypeError: can't convert MeiliSearch::Rails::Nul
lObject into Integer> with backtrace:
         # ./lib/meilisearch/rails/pagination/will_paginate.rb:13:in `create'
         # ./lib/meilisearch/rails/pagination.rb:27:in `load_pagination!'
         # ./lib/meilisearch/rails/pagination.rb:16:in `create'
         # ./lib/meilisearch-rails.rb:721:in `ms_search'

😮‍💨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant