Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JSON schema property's title to set labels when available #164

Closed
edgarrmondragon opened this issue Sep 19, 2024 · 0 comments · Fixed by #165
Closed

Use JSON schema property's title to set labels when available #164

edgarrmondragon opened this issue Sep 19, 2024 · 0 comments · Fixed by #165
Assignees
@edgarrmondragon

Comments

@edgarrmondragon
Copy link
Contributor

For example, for a setting:

hub-utils/hub_utils/meltano_util.py

Lines 285 to 289 in 8e3a87e

setting_details = {
"name": name,
"label": MeltanoUtil._get_label(name),
"description": description,
}

We could try using the title, but then fall back to MeltanoUtil._get_label(name).

Related:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edgarrmondragon edgarrmondragon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use JSON schema title for setting labels meltano/hub-utils
1 participant
@edgarrmondragon