You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Zephyr already has a collection of CRC-16 implementations that can already be compiled into an application before Memfault is enabled.
Having a (potentially) duplicated CRC-16 implementation just for Memfault is a waste of ROM (>0.5kB in this case).
I see two options to enable this:
An option to explicitly call Zephyrs implementation from the memfault port
An option to exclude the memfault_crc16_ccitt_compute implementation entirely and allow the user to provide one
Note: #83 probably needs to be resolved before this to avoid causing much confusion.
The text was updated successfully, but these errors were encountered:
Thanks for submitting this request @JordanYates ! We'll include an option to enable a user-provided implementation of memfault_crc16_ccitt_compute (renamed as memfault_crc16_compute as part of the changes for #83 ), which can be implemented like so using the Zephyr library version:
Note that you can use #define MEMFAULT_CRC16_LOOKUP_TABLE_ENABLE 0 to use a smaller implementation in the Memfault SDK, that is close to the Zephyr library implementation in size (44 bytes / 38 bytes), at the expense of performance. However if you are already using crc16_itu_t in your application, we will support that use case in the next SDK release. Let us know if you need that support urgently, otherwise it will be scheduled for some time next week I think.
Zephyr already has a collection of CRC-16 implementations that can already be compiled into an application before Memfault is enabled.
Having a (potentially) duplicated CRC-16 implementation just for Memfault is a waste of ROM (>0.5kB in this case).
I see two options to enable this:
memfault_crc16_ccitt_compute
implementation entirely and allow the user to provide oneNote: #83 probably needs to be resolved before this to avoid causing much confusion.
The text was updated successfully, but these errors were encountered: