From c0a53068e46dc5aa670b001b3570e62d9b2f2cc5 Mon Sep 17 00:00:00 2001
From: Alf-Rune Siqveland <alf.rune@northern.tech>
Date: Tue, 19 Nov 2024 10:50:06 +0100
Subject: [PATCH] test: Unit tests for configuring rate limits

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
---
 backend/services/deviceauth/server_test.go | 107 +++++++++++++++++++++
 1 file changed, 107 insertions(+)
 create mode 100644 backend/services/deviceauth/server_test.go

diff --git a/backend/services/deviceauth/server_test.go b/backend/services/deviceauth/server_test.go
new file mode 100644
index 00000000..ee9a29f4
--- /dev/null
+++ b/backend/services/deviceauth/server_test.go
@@ -0,0 +1,107 @@
+package main
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/spf13/viper"
+	"github.com/stretchr/testify/assert"
+
+	dconfig "github.com/mendersoftware/mender-server/services/deviceauth/config"
+	"github.com/mendersoftware/mender-server/services/deviceauth/devauth"
+)
+
+func TestSetupRateLimits(t *testing.T) {
+	t.Parallel()
+
+	type testCase struct {
+		Config *viper.Viper
+
+		Error error
+	}
+
+	for name, _tc := range map[string]testCase{
+		"ok/slice": {
+			Config: func() *viper.Viper {
+				cfg := viper.New()
+				cfg.Set(dconfig.SettingRatelimitsQuotas, "enterprise=1.5 professional=0.75 os=0.5")
+				return cfg
+			}(),
+		},
+		"ok/map": {
+			Config: func() *viper.Viper {
+				cfg := viper.New()
+				cfg.Set(dconfig.SettingRatelimitsQuotas, map[string]any{
+					"enterprise":   float64(2.5),
+					"professional": int(2),
+					"os":           uint64(1),
+				})
+				return cfg
+			}(),
+		},
+		"ok/no limits": {
+			Config: func() *viper.Viper {
+				cfg := viper.New()
+				return cfg
+			}(),
+		},
+		"error/negative value": {
+			Config: func() *viper.Viper {
+				cfg := viper.New()
+				cfg.Set(dconfig.SettingRatelimitsQuotas, map[string]any{"bad": -1.0})
+				return cfg
+			}(),
+			Error: fmt.Errorf("invalid config value %s[bad]: value must be a positive value",
+				dconfig.SettingRatelimitsQuotas),
+		},
+		"error/slice without separator": {
+			Config: func() *viper.Viper {
+				cfg := viper.New()
+				cfg.Set(dconfig.SettingRatelimitsQuotas, "foo bar baz")
+				return cfg
+			}(),
+			Error: fmt.Errorf("invalid config %s: value %v item #1: missing key/value separator '='",
+				dconfig.SettingRatelimitsQuotas, []string{"foo", "bar", "baz"}),
+		},
+		"error/not convertible to float": {
+			Config: func() *viper.Viper {
+				cfg := viper.New()
+				cfg.Set(dconfig.SettingRatelimitsQuotas, "enterprise=many")
+				return cfg
+			}(),
+			Error: fmt.Errorf("error parsing quota value"),
+		},
+		"error/unexpected config type": {
+			Config: func() *viper.Viper {
+				cfg := viper.New()
+				cfg.Set(dconfig.SettingRatelimitsQuotas, "")
+				return cfg
+			}(),
+			Error: fmt.Errorf("invalid config value %s: "+
+				"expected non-empty list of strings or object with numeric members",
+				dconfig.SettingRatelimitsQuotas),
+		},
+		"error/unexpected map type": {
+			Config: func() *viper.Viper {
+				cfg := viper.New()
+				cfg.Set(dconfig.SettingRatelimitsQuotas, map[string]any{"foo": "123"})
+				return cfg
+			}(),
+			Error: fmt.Errorf("invalid config value %s[foo]: "+
+				"not a numeric value",
+				dconfig.SettingRatelimitsQuotas),
+		},
+	} {
+		tc := _tc
+		t.Run(name, func(t *testing.T) {
+			da := &devauth.DevAuth{}
+			err := setupRatelimits(tc.Config, da, "n/a", nil)
+			if tc.Error != nil {
+				assert.ErrorContains(t, err, tc.Error.Error())
+			} else {
+				assert.NoError(t, err)
+			}
+		})
+	}
+
+}