Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers without value can't be parsed #6

Open
henrikjonhed opened this issue Feb 7, 2017 · 2 comments
Open

Headers without value can't be parsed #6

henrikjonhed opened this issue Feb 7, 2017 · 2 comments

Comments

@henrikjonhed
Copy link

A header that does not have a value, but a carriage return directly after the colon will put the parser in state http_roundtripper_error. I guess that the webserver that returns this kind of header is the one to blame, but it would be nice to be able to receive data from it anyway.
screenshot 2017-02-03 12 44 48

@ledbit
Copy link

ledbit commented Apr 24, 2017

I actually thing that the fix should be

-    0x87,    6, 0xC1, 0xC1,    6, 0x87, 0x87, 0xC1, /* state 6: leading whitespace before header value */
+    0x87,    6, 0xC4,   10,    6, 0x87, 0x87, 0xC1, /* state 6: leading whitespace before header value */

@RalphCorderoy
Copy link

Hi @ledbit, Do you mean 0x10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants