Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install without GraphQL results in many warnings #175

Open
vinnymac opened this issue Jan 11, 2021 · 1 comment
Open

Install without GraphQL results in many warnings #175

vinnymac opened this issue Jan 11, 2021 · 1 comment

Comments

@vinnymac
Copy link

Summary

After adding nest-raven to a new project I am seeing a lot of new warnings when a project has no dependence on GraphQL.

See screenshot below.

Screen Shot 2021-01-10 at 11 36 26 PM

Any recommendations for working around this? I am aware that @nestjs/graphql is an optionalDependency, and yarn doesn't seem able to disable an optional dependency for a single package.

Perhaps another version of nest-raven could exist just for the GraphQL dependency? Such as nest-graphql-raven? I could see this repository containing multiple packages similar to others like babel, nestjs, react-router, etc do today.

@grimurd
Copy link

grimurd commented Jun 3, 2021

I'd suggest changing it to a peer dependency and mark it optional in peerDependenciesMeta

That way it will only use it if the parent module has it installed.

EDIT: According to this comment that wouldn't work as the module currently doesn't work without graphql.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants