Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use handler decorators to define Raven tags? #23

Open
eropple opened this issue Oct 15, 2019 · 1 comment
Open

Use handler decorators to define Raven tags? #23

eropple opened this issue Oct 15, 2019 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@eropple
Copy link

eropple commented Oct 15, 2019

Hey, me again. Haven't yet gotten around to the last two issues but wanted to drop this in before I forget.

I'm a really big fan of avoiding @UseInterceptors. It requires users to remember to add them. On the other hand, by using APP_INTERCEPTOR you're limited to the configuration values applied at interceptor creation, at a global level.

Maybe instead we can leverage decorators? I like namespacing my decorators with the package, so maybe something like @Raven.Tags(['foo', 'bar']) would be a good way to add tags to a scope on entry into the handler?

I've never used websockets in anger in NestJS, so I'm not sure if there's a good way to do similar there.

Any thoughts?

@mentos1386
Copy link
Owner

Hm, that's a good idea. I was thinking about that. This should definitely be implemented. It could even be done as another module, providing just decorator functionality. As it isn't nest specific.

@mentos1386 mentos1386 added the enhancement New feature or request label Nov 13, 2019
@mentos1386 mentos1386 added this to the v6.0.0 milestone Nov 14, 2019
@mentos1386 mentos1386 self-assigned this Nov 14, 2019
@mentos1386 mentos1386 modified the milestones: v6.0.0, v7.0.0 Apr 18, 2020
@mentos1386 mentos1386 added the help wanted Extra attention is needed label Apr 18, 2020
@mentos1386 mentos1386 removed their assignment Apr 20, 2020
@9renpoto 9renpoto removed this from the v7.0.0 milestone Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants