Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go client shall handle __archive_root__ #3897

Open
de-jcup opened this issue Feb 18, 2025 · 0 comments
Open

Go client shall handle __archive_root__ #3897

de-jcup opened this issue Feb 18, 2025 · 0 comments
Assignees
Labels
Milestone

Comments

@de-jcup
Copy link
Member

de-jcup commented Feb 18, 2025

Situation

When #3776 has been implemented, it is possible to use reserved ids __binaries_archive_root__ and __sourcecode_archive_root__ as identifiers to root level for the zip or tar archive without having a data section defined inside the configuration.

The SecHub go client does currently not allow any usage of a reference id which is not listed inside the data section. If somebody would use the reserved ids without data section, the client would fail. But if used with data section ,the SecHub server will fail with a validation error (it's forbidden by server to hold a data section with this reserved ids)

Wanted

The SecHub client shall behave similar to web ui when uploaded zip file contains a root folder - means
it shall be possible to reference accept __archive_root__ when in this case.

Solution

SecHub client will

  • fail when a data section contains __binaries_archive_root__ or __sourcecode_archive_root__ definition (will be asserted on
    Server side as well, but we want to fail fast at client side)

  • the go client does always create a data section so it does not make sense
    to give here access to __binaries_archive_root__ or __sourcecode_archive_root__
    so there should be no further special handling

@sven-dmlr sven-dmlr self-assigned this Feb 19, 2025
@sven-dmlr sven-dmlr added this to the Client 1.10.0 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants