Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjoint interpolation operator is incorrect #113

Open
jwallwork23 opened this issue Apr 27, 2024 · 0 comments
Open

Adjoint interpolation operator is incorrect #113

jwallwork23 opened this issue Apr 27, 2024 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@jwallwork23
Copy link
Member

The adjoint version of the interpolate operator simply applies the standard interpolate. This is incorrect and needs to be implemented by transposing the interpolation operator.

@jwallwork23 jwallwork23 added the bug Something isn't working label Apr 27, 2024
@jwallwork23 jwallwork23 added this to the Version 1 milestone Apr 27, 2024
jwallwork23 added a commit that referenced this issue May 14, 2024
Closes #95.

This PR allows the projection operator (and its adjoint) to be mass
lumped. For P1 spaces, this implies that extrema are preserved following
the transfer.

While developing these changes, I noticed #113 and #114, so the
associated functionality and tests are turned off here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant