Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting and analysing metrics? #93

Open
ddundo opened this issue Mar 19, 2024 · 1 comment
Open

Plotting and analysing metrics? #93

ddundo opened this issue Mar 19, 2024 · 1 comment
Labels
enhancement New feature or request refactor A suggested reworking of the code
Milestone

Comments

@ddundo
Copy link
Member

ddundo commented Mar 19, 2024

I thought it would be nice to add some plotting functionality to animate for metrics. I mentioned this to @acse-ej321 on the last meeting since she showed nice figures in the past.

And potentially related to this: I feel like the density_and_quotients method of RiemannianMetric is a bit out of place there. All other methods are used to actually construct the metric, while density_and_quotients is never called, and is only used for analysis, right?

So I feel like it would be nice to have something similar to quality.py for meshes, but for metrics. And the ability to plot them easily.

@jwallwork23 jwallwork23 added the enhancement New feature or request label Mar 20, 2024
@jwallwork23 jwallwork23 added this to the Version 1 milestone Mar 20, 2024
@jwallwork23
Copy link
Member

So I have been thinking about this a bit - it links to #37. Since the RiemannianMetric class is now quite bloated, it would be nice to introduce a superclass called SPDFunction, which is a subclass of Function for the symmetric-positive definite case. Then it would make sense to move (e.g.) enforce_spd, assemble_eigendecomposition, compute_eigendecomposition, density_and_quotients there. We could also make the P0Metric class used internally a subclass of SPDFunction but not RiemannianMetric.

@jwallwork23 jwallwork23 added the refactor A suggested reworking of the code label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor A suggested reworking of the code
Projects
Development

No branches or pull requests

2 participants