Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear unnecessary fields after error indicators are computed #220

Open
ddundo opened this issue Sep 20, 2024 · 5 comments · May be fixed by #224
Open

Clear unnecessary fields after error indicators are computed #220

ddundo opened this issue Sep 20, 2024 · 5 comments · May be fixed by #224
Assignees
@acse-ej321
Labels
optimisation An opportunity to optimise performance

Comments

@ddundo
Copy link
Member

ddundo commented Sep 20, 2024 •
edited
Loading

With #212, error indicators are now computed at the end of each subinterval. This allows us to get rid of forward_old and adjoint_next fields after each subinterval, since they are no longer needed.
@ddundo ddundo self-assigned this Sep 20, 2024
@ddundo ddundo added the optimisation An opportunity to optimise performance label Sep 20, 2024
@ddundo
Copy link
Member Author

ddundo commented Oct 18, 2024 •
edited
Loading

Then we can also completely get rid of solutions on the enriched_mesh_seq after each subinterval, as well as the enriched mesh and function spaces, etc.

@jwallwork23
Copy link
Member

Nice!

@ddundo
Copy link
Member Author

ddundo commented Oct 20, 2024

@acse-ej321 assigning you since you said you'll do it :)

@ddundo ddundo assigned acse-ej321 and unassigned ddundo Oct 20, 2024
acse-ej321 added a commit that referenced this issue Oct 24, 2024
@acse-ej321
#220 minor formating changes
1ae9535
acse-ej321 added a commit that referenced this issue Oct 24, 2024
@acse-ej321
#220 make time_partition deepcopy for enriched_mesh_seq
2c9cf5a
@acse-ej321 acse-ej321 linked a pull request Oct 24, 2024 that will close this issue
Open
acse-ej321 added a commit that referenced this issue Oct 24, 2024
@acse-ej321
#220 remove unnecessary comment
d7e9f8b
@ddundo
Copy link
Member Author

ddundo commented Oct 24, 2024 •
edited
Loading

@acse-ej321 @jwallwork23 do we ever need forward_old in Hessian-based adaptations? (After each subinterval's _solve_forward, I mean)

acse-ej321 added a commit that referenced this issue Oct 24, 2024
@acse-ej321
#220 more clarity in comments for clearning subinterval fields in ind…
fb5552b 
…icate errors
acse-ej321 added a commit that referenced this issue Oct 24, 2024
@acse-ej321
#220 rebuild enriched mesh function sp
714f9ef 
ace after removing mesh subinterval
acse-ej321 added a commit that referenced this issue Oct 24, 2024
@acse-ej321
#220 add time_partition method to drop
8e78325 
 last interval
acse-ej321 added a commit that referenced this issue Oct 24, 2024
@acse-ej321
#220 add explicit copy for enriched mesh initial meshes
7752717
acse-ej321 added a commit that referenced this issue Oct 25, 2024
@acse-ej321
#220 clear solution labels and keys after indicate errors
4c0bcb6
@jwallwork23
Copy link
Member

@acse-ej321 @jwallwork23 do we ever need forward_old in Hessian-based adaptations? (After each subinterval's _solve_forward, I mean)

Probably not in general, no.

@ddundo ddundo mentioned this issue Oct 26, 2024
Open
acse-ej321 added a commit that referenced this issue Nov 9, 2024
@acse-ej321
#220 modify _fs directly, unit test for TimePartition drop_last_subin…
1b35879 
…terval
acse-ej321 added a commit that referenced this issue Nov 11, 2024
@acse-ej321
#220 remove unused imports and limit final mesh deletion
9548f0f
acse-ej321 added a commit that referenced this issue Nov 18, 2024
@acse-ej321 @jwallwork23
#220 Apply spelling corrections from code review
f6bedf7 
Co-authored-by: Joe Wallwork <[email protected]>
@jwallwork23 jwallwork23 moved this from Ready for review to Reviewed with actions in Mesh Adaptation development board Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acse-ej321 acse-ej321

Labels
optimisation An opportunity to optimise performance
Projects
Mesh Adaptation development board
Status: Reviewed with actions
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clear fields and meshes after indicate error calculated per segment mesh-adaptation/goalie
3 participants
@jwallwork23 @ddundo @acse-ej321