Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Team colors for TAK Tracker nodes #24

Open
habr05 opened this issue May 26, 2024 · 18 comments
Open

[Feature Request] Team colors for TAK Tracker nodes #24

habr05 opened this issue May 26, 2024 · 18 comments

Comments

@habr05
Copy link

habr05 commented May 26, 2024

Is there anything that prevents team color being applied to Tak Tracker nodes?

@habr05 habr05 changed the title [Feature Request] Team colors for tracker nodes [Feature Request] Team colors for TAK Tracker nodes May 27, 2024
@niccellular
Copy link
Member

niccellular commented May 29, 2024

I think this should work already? Just append the node color scheme to the end of the long name.

See here for more details
https://github.com/meshtastic/ATAK-Plugin/releases/tag/1.0.13

@habr05
Copy link
Author

habr05 commented May 29, 2024

it works for every type except "TAK TRACKER"

@habr05
Copy link
Author

habr05 commented May 29, 2024

Both, "CTmA 6924 -5" and "TARDY", are the same node. The node is configured as "TAK_TRACKER".

Screenshot 2024-05-29 174805

@niccellular
Copy link
Member

I just tested this and it's working for me?

@niccellular
Copy link
Member

Make sure you have "Show all Meshtastic devices" enabled

@habr05
Copy link
Author

habr05 commented Jun 7, 2024

So you're saying that team color, for TAK_TRACKER node type, will show only when "Show all Meshtastic devices" is enabled. Is that correct?

@niccellular
Copy link
Member

So you're saying that team color, for TAK_TRACKER node type, will show only when "Show all Meshtastic devices" is enabled. Is that correct?

Yes

@habr05
Copy link
Author

habr05 commented Jun 13, 2024

What's the reasoning behind it? Why not keep it consistent regardless of the "Show all Meshtastic devices" settings?

@niccellular
Copy link
Member

tracker nodes are meshtastic devices

@habr05
Copy link
Author

habr05 commented Jun 25, 2024

ATAK has a standalone "tracking only" app used for anything that does not have (require) user input. TAK_TRACKER would be equivalent of that app. In real life that would be useful to slap those trackers on equipment, team members or even as beacons for landing pad, medic, command post etc.

Just to make sure that we are talking about the same thing I'm including the screenshot of the selected option.

Screenshot_20240624_185952_Meshtastic

@niccellular
Copy link
Member

niccellular commented Jun 25, 2024

if you set a meshtastic device's role to tak_tracker/tracker, it is equiv the same when your eud enables show all meshtastic devices.

@habr05
Copy link
Author

habr05 commented Jun 25, 2024

the problem is that when I enable "show all..." the team color is applied to the node BUT if I disable "show all..." it is not and the appended -# shows in the name.

@niccellular
Copy link
Member

try using the "TRACKER" role not "TAK_TRACKER" i probably have a bug somewhere if what you are saying is correct. I'll try to fix it soon, but if you can try just using TRACKER role maybe it will get you going for now

@alexsh5
Copy link

alexsh5 commented Jul 8, 2024

This is the issue I have experienced for some time. You're right that it only affects the TAK TRACKER role and that using the standard TRACKER role corrects the problem. The only thing I can find that might relate is the statement before checking colours in the long name. Checks if "plugin_meshtastic_tracker" is FALSE. Does this mean it is intentionally excluding the TAK TRACKER role?

https://github.com/meshtastic/ATAK-Plugin/blob/e0423ac2e826601a9d9781895e12c847b7427921/app/src/main/java/com/atakmap/android/meshtastic/MeshtasticReceiver.java#L354

@niccellular
Copy link
Member

Its getting the value of plugin_meshtastic_tracker if it is not set then the default is false

To use the role-by-name thing, you must have that preference enabled

@RichieFrame
Copy link

For context, the reason that this does not work on TAK TRACKER is because the information arrives from those nodes in a tak packet format and already includes a team color, which is hardcoded in the firmware. I put in a feature request for this to be added to the firmware

@RichieFrame
Copy link

meshtastic/firmware#4787
I guess we vote on feature requests now? If you want this, vote for it at the above link

@habr05
Copy link
Author

habr05 commented Sep 25, 2024

meshtastic/firmware#4787 I guess we vote on feature requests now? If you want this, vote for it at the above link

voted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants