Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use structured output for interior_design app #122

Open
yanxi0830 opened this issue Nov 20, 2024 · 3 comments
Open

Use structured output for interior_design app #122

yanxi0830 opened this issue Nov 20, 2024 · 3 comments
Assignees
@Anirudh2112
Labels
good first issue Good for newcomers

Comments

@yanxi0830
Copy link
Contributor

yanxi0830 commented Nov 20, 2024 •
edited
Loading

🚀 The feature, motivation and pitch

Alternatives

No response

Additional context

No response
@yanxi0830 yanxi0830 added the good first issue Good for newcomers label Nov 20, 2024
@Anirudh2112
Copy link

Hi @yanxi0830, I would like to work on this. Could you assign this to me?

@yanxi0830
Copy link
Contributor Author

Hi @yanxi0830, I would like to work on this. Could you assign this to me?

Of course! Thanks!

@Anirudh2112
Copy link

I have made the changes and committed a PR. Please go through it and let me know if something is wrong or if any changes are required

hanzlfs added a commit to meta-llama/llama-stack-client-python that referenced this issue Dec 18, 2024
@hanzlfs
Add response args in turn.create
3f0728b 
To support meta-llama/llama-stack-apps#122

* Add response_format for turn.create
This was referenced Dec 18, 2024
Closed
Merged
ashwinb pushed a commit to meta-llama/llama-stack that referenced this issue Jan 28, 2025
@hanzlfs
Agent response format (#660)
229f0d5 
# What does this PR do?

Add response format for agents structured output.

- [ ] Using structured output for agents (interior_design app as an
example) (#issue)
meta-llama/llama-stack-apps#122


## Test Plan
E2E test plan with llama-stack-apps interior_design

Please describe:
 Test ran: 

 - provide instructions so it can be reproduced.
 Start your distro:
llama stack run llama_stack/templates/fireworks/run.yaml --env
FIREWORKS_API_KEY=<API_KEY>
 
Run api test:
```PYTHONPATH=. python examples/interior_design_assistant/api.py localhost 5000 examples/interior_design_assistant/resources/documents/ examples/interior_design_assistant/resources/images/fireplaces```


## Sources
Results: 
meta-llama/llama-stack-client-python#72

## Before submitting

- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [ ] Ran pre-commit to handle lint / formatting issues.
- [x] Read the [contributor guideline](https://github.com/meta-llama/llama-stack/blob/main/CONTRIBUTING.md),
      Pull Request section?
- [ ] Updated relevant documentation.
- [ ] Wrote necessary unit or integration tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anirudh2112 Anirudh2112

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yanxi0830 @Anirudh2112