-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server defaults to port 8321 ignoring configured server port from yaml #1076
Comments
At first glance, it seems to me that the CLI flag takes precedence over the config file, this is a common behavior. At least that's what you example shows. Did I miss something? |
@leseb in the absence of specifying a CLI flag, As you can see from my copy/paste, I did not set a CLI flag, but So perhaps the subject of the issue is not quite accurate -- perhaps it should be:
|
Ensure that the options follow the correct priority order: 1. Environment variable (eg: `LLAMA_STACK_PORT`) takes the highest precedence. 2. CLI flag (`--port`) is considered only if the env variable is unset. 3. Config file value (`config.server.port`) is used as a fallback. 4. Default port (`8321`) is the last resort. Closes: meta-llama#1076 Signed-off-by: Sébastien Han <[email protected]>
Oh right thanks for clarifying, I could repro and sent a patch! |
@leseb nice! glad I was able to clear it up. |
Ensure that the options follow the correct priority order: 1. Environment variable (eg: `LLAMA_STACK_PORT`) takes the highest precedence. 2. CLI flag (`--port`) is considered only if the env variable is unset. 3. Config file value (`config.server.port`) is used as a fallback. 4. Default port (`8321`) is the last resort. Closes: meta-llama#1076 Signed-off-by: Sébastien Han <[email protected]>
Ensure that the options follow the correct priority order: 1. Environment variable (eg: `LLAMA_STACK_PORT`) takes the highest precedence. 2. CLI flag (`--port`) is considered only if the env variable is unset. 3. Config file value (`config.server.port`) is used as a fallback. 4. Default port (`8321`) is the last resort. Closes: meta-llama#1076 Signed-off-by: Sébastien Han <[email protected]>
Ensure that the options follow the correct priority order: 1. Environment variable (eg: `LLAMA_STACK_PORT`) takes the highest precedence. 2. CLI flag (`--port`) is considered only if the env variable is unset. 3. Config file value (`config.server.port`) is used as a fallback. 4. Default port (`8321`) is the last resort. Closes: meta-llama#1076 Signed-off-by: Sébastien Han <[email protected]>
Ensure that the options follow the correct priority order: 1. Environment variable (eg: `LLAMA_STACK_PORT`) takes the highest precedence. 2. CLI flag (`--port`) is considered only if the env variable is unset. 3. Config file value (`config.server.port`) is used as a fallback. 4. Default port (`8321`) is the last resort. Closes: meta-llama#1076 Signed-off-by: Sébastien Han <[email protected]>
Ensure that the options follow the correct priority order: 1. Environment variable (eg: `LLAMA_STACK_PORT`) takes the highest precedence. 2. CLI flag (`--port`) is considered only if the env variable is unset. 3. Config file value (`config.server.port`) is used as a fallback. 4. Default port (`8321`) is the last resort. Closes: meta-llama#1076 Signed-off-by: Sébastien Han <[email protected]>
System Info
N/A
Information
🐛 Describe the bug
I did a build with
venv
and modifiedconfig.yaml
to specify the server port:When running, if a port argument isn't specified, the port is automatically forcibly set by default, an the configured port is ignored:
Error logs
n/a
Expected behavior
server should use the configured port from the yaml and not forcibly set one ignoring the config.
The text was updated successfully, but these errors were encountered: