Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break out the metrics service test #2173

Open
lentzi90 opened this issue Jan 9, 2025 · 2 comments
Open

Break out the metrics service test #2173

lentzi90 opened this issue Jan 9, 2025 · 2 comments
Assignees
@kashifest
Labels
triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@lentzi90
Copy link
Member

lentzi90 commented Jan 9, 2025

The metrics service test is currently sitting inline in the e2e_suite_test.go. This was done just as a temporary quick implementation and should now be cleaned up. The test should be moved to its own proper test file.
We can also consider changing it to not use kubectl, but the API directly.
@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label Jan 9, 2025
@lentzi90
Copy link
Member Author

lentzi90 commented Jan 9, 2025

/triage accepted

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Jan 9, 2025
@kashifest
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kashifest kashifest

Labels
triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lentzi90 @kashifest @metal3-io-bot