Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on Load of Bad .auto file #60

Open
FeralRants opened this issue Apr 12, 2019 · 2 comments
Open

Crash on Load of Bad .auto file #60

FeralRants opened this issue Apr 12, 2019 · 2 comments

Comments

@FeralRants
Copy link

If you load a file that isn't actually a .auto file it crashes the program.

Was just wondering what the program would do if I changed a txt file to a .auto and obviously it doesn't like that. Crashes without any error message or anything. Don't know if this is helpful or not, but figured it was worth at least a report.

@AustinHaugerud
Copy link

AustinHaugerud commented Apr 14, 2019

@metherul
From what I can tell this can be fixed by adding a catch block or properly bubbling the exception in ArchiveContents.cs concerning the call to ArchiveFactory::Open from SharpCompress.

Notice the throw statement here.

https://github.com/adamhathcock/sharpcompress/blob/4e5b70dbfa89ed10417072c47854031503c17d73/src/SharpCompress/Archives/ArchiveFactory.cs#L59

@metherul
Copy link
Owner

We can most likely wrap the call within Automaton with a try/catch block and then route it off to be shown by a non-fatal dialog handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants