Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlimpseDataPainter2D should not hide GlimpseContext #15

Open
ulmangt opened this issue Jun 13, 2012 · 0 comments
Open

GlimpseDataPainter2D should not hide GlimpseContext #15

ulmangt opened this issue Jun 13, 2012 · 0 comments
Assignees

Comments

@ulmangt
Copy link
Member

ulmangt commented Jun 13, 2012

GlimpseDataPainter2D.paintTo() passes a GL handle but not the entire GlimpseContext. This makes it impossible to call the paintTo() method of other delegate painters which are not GlimpseDataPainter2D.

Suggest potentially moving the bounds.isValid() check up to GlimpsePainter2D, removing the axis null checks (which are redundant because GlimpsePainter2D makes those checks), and having users override paintTo() and call super.paintTo().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant