Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal background color #18

Open
ghost opened this issue Nov 10, 2014 · 1 comment · May be fixed by #20
Open

Modal background color #18

ghost opened this issue Nov 10, 2014 · 1 comment · May be fixed by #20

Comments

@ghost
Copy link

ghost commented Nov 10, 2014

Why background: rgba(0, 0, 0, .5) option is set? It overrides original Bootstrap background, where color can be changed.

dankahle added a commit to dankahle/angular-motion that referenced this issue Feb 14, 2015
Change backdrop to use bootstrap color instead.

 Fixes: mgcrea#18
dankahle added a commit to dankahle/angular-motion that referenced this issue Feb 14, 2015
Change backdrop to use bootstrap color instead.

 Fixes: mgcrea#18
@dankahle
Copy link

The existing code that utilizes am-fade works currently (on bootstrap 3.2.0 at least), whereas the angular-strap docs offer a user-entered transition solution. The transition solution doesn't set a color and as such, "would" use boots modal background color, and also has the opacity set to .5, so perfect, but... motion's .modal-backdrop.am-fade selector is more specific and as such overrides, and not only that, but overrides black/opacity .5, which coupled with the transition to opacity .5 yields an overall opacity of .25, so ends up being too light at as well.

I favor the idea of adding the transition code to all of motion's animation .less files, then whatever the option.backdropAnimation is set to, it will yield the correct results without user entering code. I tried the transition code from the docs, but the am-fade animation code was messing it up, so needs to be animation code instead. Just put a PR in for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant