-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Password reset not public by default #71
Comments
Total oversight, I will add them! |
Bah, I have been slow. I am adding this to my todo list right now to resolve. Really sorry about this! |
Adding them to settings manually like below doesn't help. Am I missing something?
It works as it should with the stronghold middelware disabled. Using Django 2.0 and Stronghold 0.3.0. |
@pvandegeer add them not by name but by pattern, related to #33 I think. |
I just ran into this. For anyone else, it is indeed pretty straightforward to work around. I set up the following public URLs: STRONGHOLD_PUBLIC_NAMED_URLS = (
"password_reset",
"password_reset_done",
"password_reset_confirm",
"password_reset_complete",
)
STRONGHOLD_PUBLIC_URLS = ("^/accounts/reset/.*",) To work around it. |
For people who are using django-allauth add this to the configs: STRONGHOLD_PUBLIC_URLS = ("/accounts/password/reset/key/.*", "/accounts/confirm-email/.*",)
STRONGHOLD_PUBLIC_NAMED_URLS = (
'account_signup',
'account_login',
'account_reset_password',
'account_reset_password_done',
'account_reset_password_from_key',
'account_reset_password_from_key_done',
'account_email_verification_sent',
'account_confirm_email'
) |
Urls for login and logout are public if
django.contrib.auth
is installed but not password_reset, password_reset_done, password_reset_confirm nor password_reset_complete.Could you add theses ? I can make a PR later if you prefer.
The text was updated successfully, but these errors were encountered: