Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when dealing with array of strings in API #49

Closed

Conversation

arthurnobrega
Copy link

Fix #48

@codeclimate
Copy link

codeclimate bot commented Feb 27, 2020

Code Climate has analyzed commit 7fdabf2 and detected 0 issues on this pull request.

View more on Code Climate.

@@ -1,4 +1,6 @@
env:
- ACTIVE_CAMPAIGN_URL=https://account.api-us1.com/api/3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remind me again why this change is needed? Obviously it is 6am and I am still just waking up but I can't figure this one out :)

Is it because of running the cassettes for merged pull requests?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mhenrixon, I was trying to fix a error I received when running the pipeline in TravisCI: https://travis-ci.com/mhenrixon/active_campaign/jobs/291594389

But I'm not sure if it was the problem. Can you help me to find out this error in TravisCI?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be under global: then? The key is provided as a secret from travis in my branch.

@arthurnobrega arthurnobrega deleted the fix/api-array-of-strings branch October 16, 2020 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined method `each_with_object' for "400":String
2 participants